티스토리 수익 글 보기
{{ message }}
Allow fromstring with buffer objects – #448
Closed
jsonn wants to merge 1 commit into
Closed
Conversation
Database adapters like psycopg will use memoryview objects to represent binary strings. There is no need to force applications to copy the data to bytes manually as the logic already works fine for buffer objects. As such, just relax the type check.
Member
|
Thanks. I think generally checking for the buffer interface would be better than adding only memoryview.
|
Author
|
AFAICT, memoryview is how the buffer interface is exposed as Python object at least in Python 3. In Py2, there was also “buffer”, but upstream lxml no longer has to care about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database adapters like psycopg will use memoryview objects to represent binary strings. There is no need to force applications to copy the data to bytes manually as the logic already works fine for buffer objects. As such, just relax the type check.