티스토리 수익 글 보기

티스토리 수익 글 보기

Fix CI static analysis on Windows by priethor · Pull Request #73911 · WordPress/gutenberg · GitHub
Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Dec 11, 2025

What?

Tries to fix the Windows CI build failure as a follow-up to #73860.

Why?

The plugin is passing an absolute Windows path to Terrazzo’s outputFile function. Internally, outputFile calls new URL(filename, config.outDir), which fails because Windows paths are not valid URL strings.

How?

Instead of converting URLs to paths, work entirely with URLs; this is cross-platform because the URL API handles path differences automatically.

Testing

Check that npm run --workspace @wordpress/theme build passes locally

Screenshots

Before After
imagen imagen

@priethor priethor requested a review from aduth December 11, 2025 11:31
@priethor priethor added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 11, 2025
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 11, 2025
@priethor priethor removed the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 11, 2025
@priethor
Copy link
Contributor Author

Deleting the First-time contributor comment and labels because they are not accurate 😅

@WordPress WordPress deleted a comment from github-actions bot Dec 11, 2025
@priethor
Copy link
Contributor Author

Confirmed this solves the issue on a Windows machine, marking the PR as ready.

@priethor priethor marked this pull request as ready for review December 11, 2025 11:56
@priethor priethor requested a review from a team as a code owner December 11, 2025 11:56
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you’re merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: priethor <priethor@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project’s expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor changed the title Try: fix CI static analysis on Windows Fix CI static analysis on Windows Dec 11, 2025
@github-actions
Copy link

Flaky tests detected in ee33198.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20131655863
📝 Reported issues:

@priethor priethor merged commit 1f89706 into trunk Dec 11, 2025
43 checks passed
@priethor priethor deleted the try/fix-windows-ci branch December 11, 2025 12:49
@github-actions github-actions bot added this to the Gutenberg 22.4 milestone Dec 11, 2025
@aduth
Copy link
Member

aduth commented Dec 11, 2025

For posterity, @t-hamano separately opened a fix at #73900, which we should be able to close now since this is merged.

@priethor
Copy link
Contributor Author

priethor commented Dec 11, 2025

Thanks @aduth and @t-hamano and apologies , I can’t believe I didn’t see that 🤦

I tried shipping this ASAP to get trunk back ready (especially since, as far as I know, most active contributors don’t have a Windows environment to test); this gets the job done, but if you find the other approach more suitable, by all means feel free to ship it.

@priethor priethor added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Dec 17, 2025
@priethor
Copy link
Contributor Author

I just cherry-picked this PR to the release/22.3 branch to get it included in the next release: 986ec35

priethor added a commit that referenced this pull request Dec 17, 2025
@priethor priethor removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants