티스토리 수익 글 보기
{{ message }}
Simplify retrieval of book full-text, get rid of rsync, prefer epub3 to epub #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b7e831 to
1978122
Compare
1978122 to
066382a
Compare
rgaudin
approved these changes
Mar 31, 2025
Member
rgaudin
left a comment
There was a problem hiding this comment.
LGTM ; not tested.
I saw a mention of multiple passes ; do we still do that? How so?
Collaborator
Author
Of course, will be done before publishing ZIMs again anyway
Where ? We don’t AFAIK ^^ |
rgaudin
reviewed
Apr 1, 2025
| unoptimized_fpath = unoptimized_dir / fname_for(book, book_format) | ||
| logger.debug(f"Processing {book_format}") | ||
|
|
||
| # if we already know (e.g. due to a former pass) that this book format is not |
Collaborator
Author
There was a problem hiding this comment.
OK, got it.
We don’t do it on the Zimfarm. But scraper is mostly capable to support it, typically when you run the tool twice with different settings while keeping temporary files. So I ensured I did not introduced any regression on this “functionality” + optimized a bit code behavior at this download stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97
Fix #219
Fix #235
Fix #160
Changes:
UrlDB tableBookFormatDB tableunsupported_formatscolumn inBookDB table, containing a CSV of formats known to not be present for a given book (e.g.pdf,epub)I willI’ve open a PR in this repo: Cosmetic changes to please ruff standard rules gutenbergtools/libgutenberg#47)