티스토리 수익 글 보기
{{ message }}
Fix disabled breakpoint icon in disassembly view – #143925
Merged
roblourens merged 2 commits intoMar 14, 2022
Merged
Conversation
Contributor
Author
|
roblourens Andre Weinand (@weinand) Can you please take a look at this PR? |
Andre Weinand (weinand)
suggested changes
Feb 24, 2022
Andre Weinand (weinand)
left a comment
Andre Weinand (weinand)
left a comment
Contributor
There was a problem hiding this comment.
other than the typo looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like when disabling breakpoint was implemented for the disassembly view, the disabled breakpoint icon wasn’t added. This PR adds it.