티스토리 수익 글 보기

티스토리 수익 글 보기

Build: fix Makefile to work on systems without `which(1)` by mgorny · Pull Request #416 · lxml/lxml · GitHub
Skip to content

Build: fix Makefile to work on systems without which(1) – #416

Merged
scoder merged 1 commit into
lxml:masterfrom
mgorny:no-which
Apr 1, 2024
Merged

Build: fix Makefile to work on systems without which(1)#416
scoder merged 1 commit into
lxml:masterfrom
mgorny:no-which

Conversation

@mgorny

@mgorny mgorny commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Replace the use of third-party which(1) executable with the shell command -v builtin. This avoids unnecessary dependency on a third-party executable, in favor of a shell builtin that is guaranteed by POSIX, and therefore fixes building documentation on systems that no longer installs which(1) by default, such as Gentoo Linux.

Replace the use of third-party `which(1)` executable with the shell
`command -v` builtin.  This avoids unnecessary dependency
on a third-party executable, in favor of a shell builtin that is
guaranteed by POSIX, and therefore fixes building documentation
on systems that no longer installs `which(1)` by default,
such as Gentoo Linux.
@scoder

scoder commented Apr 1, 2024

Copy link
Copy Markdown
Member

Thanks. Probably ok, but I’m still triggering a fresh build to make sure everything builds.

@scoder scoder closed this Apr 1, 2024
@scoder scoder reopened this Apr 1, 2024
@scoder
scoder merged commit 24dafd3 into lxml:master Apr 1, 2024
@scoder

scoder commented Apr 1, 2024

Copy link
Copy Markdown
Member

I’ll add this to 5.2.1.

@mgorny

mgorny commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

Thanks a lot!

@mgorny
mgorny deleted the no-which branch April 2, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants