티스토리 수익 글 보기

티스토리 수익 글 보기

[4.2.x] Fixed CVE-2026-4292 — Disallowed instance creation via Model… · django/django@abfe1a1 · GitHub
Skip to content

Commit abfe1a1

Browse files
[4.2.x] Fixed CVE-2026-4292 — Disallowed instance creation via ModelAdmin.list_editable.
Thanks Natalia Bidart, Jake Howard, and Markus Holtermann for reviews. Backport of 6afe7ce from main.
1 parent 051f390 commit abfe1a1

4 files changed

Lines changed: 39 additions & 1 deletion

File tree

django/contrib/admin/options.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
from django.contrib.admin.widgets import AutocompleteSelect, AutocompleteSelectMultiple
3131
from django.contrib.auth import get_permission_codename
3232
from django.core.exceptions import (
33+
BadRequest,
3334
FieldDoesNotExist,
3435
FieldError,
3536
PermissionDenied,
@@ -2016,6 +2017,8 @@ def changelist_view(self, request, extra_context=None):
20162017
for form in formset.forms:
20172018
if form.has_changed():
20182019
obj = self.save_form(request, form, change=True)
2020+
if obj._state.adding:
2021+
raise BadRequest("list_editable does not allow adding.")
20192022
self.save_model(request, obj, form, change=True)
20202023
self.save_related(request, form, formsets=[], change=True)
20212024
change_msg = self.construct_change_message(

docs/releases/4.2.30.txt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,13 @@ forged ``POST`` data in
3636

3737
This issue has severity "low" according to the :ref:`Django security policy
3838
<security-disclosure>`.
39+
40+
CVE-2026-4292: Privilege abuse in ``ModelAdmin.list_editable``
41+
==============================================================
42+
43+
Admin changelist forms using
44+
:attr:`~django.contrib.admin.ModelAdmin.list_editable` incorrectly allowed new
45+
instances to be created via forged ``POST`` data.
46+
47+
This issue has severity "low" according to the :ref:`Django security policy
48+
<security-disclosure>`.

tests/admin_views/admin.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,14 @@ def get_queryset(self, request):
358358
return super().get_queryset(request).order_by("age")
359359

360360

361+
class ParentWithUUIDPKAdmin(admin.ModelAdmin):
362+
list_display = ("id", "title")
363+
list_editable = ("title",)
364+
365+
def has_add_permission(self, request):
366+
return False
367+
368+
361369
class FooAccountAdmin(admin.StackedInline):
362370
model = FooAccount
363371
extra = 1
@@ -1244,7 +1252,7 @@ class TravelerAdmin(admin.ModelAdmin):
12441252
site.register(InlineReferer, InlineRefererAdmin)
12451253
site.register(ReferencedByGenRel)
12461254
site.register(GenRelReference)
1247-
site.register(ParentWithUUIDPK)
1255+
site.register(ParentWithUUIDPK, ParentWithUUIDPKAdmin)
12481256
site.register(RelatedPrepopulated, search_fields=["name"])
12491257
site.register(RelatedWithUUIDPKModel)
12501258
site.register(ReadOnlyRelatedField, ReadOnlyRelatedFieldAdmin)

tests/admin_views/tests.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import os
33
import re
44
import unittest
5+
from http import HTTPStatus
56
from unittest import mock
67
from urllib.parse import parse_qsl, urljoin, urlparse
78

@@ -4100,6 +4101,22 @@ def test_post_submission(self):
41004101

41014102
self.assertIs(Person.objects.get(name="John Mauchly").alive, False)
41024103

4104+
def test_forged_post_submission_when_no_add_permission(self):
4105+
before_count = ParentWithUUIDPK.objects.count()
4106+
data = {
4107+
"form-TOTAL_FORMS": "1",
4108+
"form-INITIAL_FORMS": "0",
4109+
"form-MAX_NUM_FORMS": "0",
4110+
"form-0-title": "The News",
4111+
"form-0-id": "",
4112+
"_save": "Save",
4113+
}
4114+
# This model admin allows no add permissions.
4115+
changelist_url = reverse("admin:admin_views_parentwithuuidpk_changelist")
4116+
response = self.client.post(changelist_url, data)
4117+
self.assertEqual(response.status_code, HTTPStatus.BAD_REQUEST)
4118+
self.assertEqual(ParentWithUUIDPK.objects.count(), before_count)
4119+
41034120
def test_non_field_errors(self):
41044121
"""
41054122
Non-field errors are displayed for each of the forms in the

0 commit comments

Comments
 (0)