[3.2.x] Fixed #30530, CVE-2021-44420 -- Fixed potential bypass of an upstream access control based on URL paths.

apollo13 · felixxm · commit 333c65603032 · 2021-12-07T06:32:24.000+01:00
Thanks Sjoerd Job Postmus and TengMA(@te3t123) for reports. Backport of d4dcd5b from main.
diff --git a/django/urls/resolvers.py b/django/urls/resolvers.py
@@ -154,7 +154,11 @@ def __init__(self, regex, name=None, is_endpoint=False):
         self.converters = {}
 
     def match(self, path):
-        match = self.regex.search(path)
+        match = (
+            self.regex.fullmatch(path)
+            if self._is_endpoint and self.regex.pattern.endswith('$')
+            else self.regex.search(path)
+        )
         if match:
             # If there are any named groups, use those as kwargs, ignoring
             # non-named groups. Otherwise, pass all non-named arguments as
@@ -244,7 +248,7 @@ def _route_to_regex(route, is_endpoint=False):
         converters[parameter] = converter
         parts.append('(?P<' + parameter + '>' + converter.regex + ')')
     if is_endpoint:
-        parts.append('$')
+        parts.append(r'\Z')
     return ''.join(parts), converters
 
 
diff --git a/docs/releases/2.2.25.txt b/docs/releases/2.2.25.txt
@@ -6,4 +6,8 @@ Django 2.2.25 release notes
 
 Django 2.2.25 fixes a security issue with severity "low" in 2.2.24.
 
-...
+CVE-2021-44420: Potential bypass of an upstream access control based on URL paths
+=================================================================================
+
+HTTP requests for URLs with trailing newlines could bypass an upstream access
+control based on URL paths.
diff --git a/docs/releases/3.1.14.txt b/docs/releases/3.1.14.txt
@@ -6,4 +6,8 @@ Django 3.1.14 release notes
 
 Django 3.1.14 fixes a security issue with severity "low" in 3.1.13.
 
-...
+CVE-2021-44420: Potential bypass of an upstream access control based on URL paths
+=================================================================================
+
+HTTP requests for URLs with trailing newlines could bypass an upstream access
+control based on URL paths.
diff --git a/docs/releases/3.2.10.txt b/docs/releases/3.2.10.txt
@@ -4,8 +4,13 @@ Django 3.2.10 release notes
 
 *December 7, 2021*
 
-Django 3.2.10 fixes a security issue with severity "low" and several bugs in
-3.2.9.
+Django 3.2.10 fixes a security issue with severity "low" and a bug in 3.2.9.
+
+CVE-2021-44420: Potential bypass of an upstream access control based on URL paths
+=================================================================================
+
+HTTP requests for URLs with trailing newlines could bypass an upstream access
+control based on URL paths.
 
 Bugfixes
 ========
diff --git a/tests/urlpatterns/tests.py b/tests/urlpatterns/tests.py
@@ -157,6 +157,19 @@ def test_whitespace_in_route(self):
         match = p.resolve('space%s/1/' % string.whitespace)
         self.assertEqual(match.kwargs, {'num': 1})
 
+    def test_path_trailing_newlines(self):
+        tests = [
+            '/articles/2003/\n',
+            '/articles/2010/\n',
+            '/en/foo/\n',
+            '/included_urls/extra/\n',
+            '/regex/1/\n',
+            '/users/1/\n',
+        ]
+        for url in tests:
+            with self.subTest(url=url), self.assertRaises(Resolver404):
+                resolve(url)
+
 
 @override_settings(ROOT_URLCONF='urlpatterns.converter_urls')
 class ConverterTests(SimpleTestCase):
