If these don’t exist, then there should be something indicating as such in the data to say that Opcache is not available, right?

Yes, the only data available if that doesn’t exists is

But if that opcache_get_status is exists, we will having this:

I can only think of those fields but I’m sure we should come up with agreed set of information first before finalizing the display.

It seems this should be referred to throughout as “Opcode Cache” per https://core.trac.wordpress.org/ticket/63697#comment:2

Thanks! – I’ll update it together with the labels

What if $opcache_status['opcache_enabled'] is false? Will the $opcache_status['memory_usage'] and $opcache_status['opcache_statistics'] keys be set. It seems these two conditions fields should be be set conditionally when $opcache_status['opcache_enabled'] is true, no?

Based on https://www.php.net/manual/en/function.opcache-get-status.php, these keys should still be accessible even when the $opcache_status['opcache_enabled'] is false, though it wouldn’t hurt if we add conditional statement

Alternatively, shouldn’t opcode_cache_memory_usage and opcode_cache_hit_rate be omitted if $opcache_status['opcache_enabled'] is false?

In other words, wrap these two assignments with a if ( $opcache_status['opcache_enabled'] ) { ... } check?

That’s correct – I’m wrapping this inside if statement

Added the conditional extra info only if the opcache_enabled is true: b8ee643

What if opcache_get_status( false ) returns false as seen in class-wp-debug-data.php above?

Used the same logic as on the class-wp-debug-data.php. We only use the opcache_enabled value in order to display the recommended status or not.

I see this is only being added to the debug data. Is this intentionally not included in the Site Health test?

You mean displaying the data inside this condition in the site health status? Do we need to do it though?

I suppose not.

Sorry, my suggestion was missing the last character.

The error message is redundant. Since the label already states “Opcode cache is not enabled”, the description should not repeat this information. Consider changing the message to something like “Enabling opcode cache can significantly improve the performance of your site.” to avoid repetition.

The URL should be escaped using esc_url() for consistency with WordPress best practices, even though it’s a hardcoded external URL. Similar patterns in the codebase (like line 2552 for persistent object cache) use esc_url() to sanitize URLs before output.

For consistency with the check in class-wp-site-health.php (line 2769), consider using strict comparison with true here: $opcache_status[‘opcache_enabled’] === true. This ensures the value is explicitly boolean true rather than any truthy value.

The new get_test_opcode_cache() method lacks test coverage. Similar test methods in this class (like get_test_page_cache() and get_test_autoloaded_options()) have corresponding tests in tests/phpunit/tests/admin/wpSiteHealth.php. Consider adding tests to cover different scenarios: opcache enabled, disabled, not available, and when opcache_get_status() returns false.

The test identifier should be ‘opcode_cache’ to match the test registration in the get_tests() method at line 2898. Currently it’s ‘opcache_cache’ which creates an inconsistency.

Array keys should be checked for existence before access. After opcache_get_status() returns a non-false value, the code assumes ‘opcache_enabled’ key exists. While this key is typically present, defensive programming would check isset($status[‘opcache_enabled’]) before accessing it to avoid potential undefined array key warnings.

Array keys should be checked for existence before access. The code assumes ‘opcache_enabled’ key exists in the $opcache_status array. Add isset() checks to avoid potential undefined array key warnings when the opcache_get_status() return structure is unexpected.

Array keys should be checked for existence before access. The code directly accesses nested array keys like $opcache_status[‘memory_usage’][‘used_memory’], $opcache_status[‘memory_usage’][‘free_memory’], and $opcache_status[‘opcache_statistics’][‘opcache_hit_rate’] without verifying they exist. Add isset() checks for these nested keys to prevent undefined array key warnings if the opcache_get_status() structure is incomplete or unexpected.