티스토리 수익 글 보기
Escape get_search_query() in bundled themes
#6685
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project’s expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| </span> | ||
| </label> | ||
| <input type=”search” id=”<?php echo $unique_id; ?>” class=”search-field” placeholder=”<?php echo esc_attr_x( ‘Search …‘, ‘placeholder‘, ‘twentyseventeen‘ ); ?>” value=”<?php echo get_search_query(); ?>” name=”s” /> | ||
| <input type=”search” id=”<?php echo $unique_id; ?>” class=”search-field” placeholder=”<?php echo esc_attr_x( ‘Search …‘, ‘placeholder‘, ‘twentyseventeen‘ ); ?>” value=”<?php echo esc_attr( get_search_query() ); ?>” name=”s” /> |
There was a problem hiding this comment.
I believe we don’t need to add esc_attr in this case. get_search_query() already use esc_attr by default on the return value.
There was a problem hiding this comment.
No, that doesn’t seem necessary. I had figured that the authors of about 850 themes knew something I didn’t.
That also makes me question whether esc_html() would add any value, but I will revert the esc_attr() changes for now.
There was a problem hiding this comment.
Adding the esc_html() make sens to me.
|
|
||
| $archive_title = sprintf( | ||
| ‘%1$s %2$s‘, | ||
| ‘%1$s “%2$s”‘, |
There was a problem hiding this comment.
The quotation marks probably should have been translatable.
| ‘%1$s “%2$s”‘, | |
| /* translators: Main heading for the Search results template. 1: “Search:” text, 2: search query. */ | |
| __( ‘%1$s “%2$s”‘, ‘twentytwenty‘ ), |
|
I updated each of the Search template headings to use |
|
Committed in r61427 |
esc_html()insearch.phptemplatesesc_attr()insearchform.phptemplatesTrac 58127
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.