티스토리 수익 글 보기
{{ message }}
Allow module can-load.php callbacks to return a WP_Error with more information
#891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Nov 30, 2023
swissspidy
reviewed
Nov 30, 2023
swissspidy
reviewed
Nov 30, 2023
Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy
approved these changes
Nov 30, 2023
felixarntz
reviewed
Nov 30, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @mukeshpanchal27, this looks great. Only a few minor points of feedback on wording and adding a @since annotation for the technically (low-level) breaking change on the function return value.
tests/testdata/demo-modules/check-error/demo-module-4/can-load.php
Outdated
Show resolved
Hide resolved
can-load.php callbacks to return a WP_Error with more information
Member
|
Milestoning this and #290 for 2.8.0 – not critical, but both of them look very good and we can probably include them in that release. Potentially we can even merge them tomorrow already. |
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Member
Author
|
Thanks for the feedback. The PR is ready for final review and merge. |
felixarntz
approved these changes
Dec 1, 2023
Member
felixarntz
left a comment
There was a problem hiding this comment.
Thank you for the updates @mukeshpanchal27, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followup work discussed here: #885 (comment)
This PR updates can load infrastructure so that it will support the custom message.
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.