티스토리 수익 글 보기

티스토리 수익 글 보기

Add a hotfix replacing the pipe character by obulat · Pull Request #5496 · WordPress/openverse · GitHub
Skip to content

Add a hotfix replacing the pipe character #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obulat merged 1 commit into from
Oct 18, 2025
Merged

Add a hotfix replacing the pipe character #5496

obulat merged 1 commit into from
Oct 18, 2025

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Oct 18, 2025

Fixes

Fixes #5495 by @obulat

Description

This PR adds a hotfix removing the pipes from Hindi locale if the English value doesn’t have a pipe.

Testing Instructions

The build should succeed

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 18, 2025 05:07
@obulat obulat requested review from dhruvkb and krysal October 18, 2025 05:07
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 18, 2025
@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Oct 18, 2025
@obulat
Add a hotfix replacing the pipe character
1ea8b1c 
Signed-off-by: Olga Bulat <obulat@gmail.com>

Revert "Add a hotfix replacing the pipe character"

This reverts commit 72b0084.
@obulat obulat force-pushed the fix/pipe-character-in-hi branch from 72b0084 to 1ea8b1c Compare October 18, 2025 05:28
@github-actions
Copy link

github-actions bot commented Oct 18, 2025

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 400      ✗ 0   
     data_received..................: 95 MB   394 kB/s
     data_sent......................: 53 kB   218 B/s
     http_req_blocked...............: avg=78.14µs  min=2.4µs    med=4.72µs   max=1.41ms   p(90)=155.88µs p(95)=378.55µs
     http_req_connecting............: avg=54.55µs  min=0s       med=0s       max=1.34ms   p(90)=99.24µs  p(95)=226.67µs
     http_req_duration..............: avg=150.99ms min=16.6ms   med=96.52ms  max=936.87ms p(90)=364.94ms p(95)=424.47ms
       { expected_response:true }...: avg=150.99ms min=16.6ms   med=96.52ms  max=936.87ms p(90)=364.94ms p(95)=424.47ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 400 
     http_req_receiving.............: avg=160.05µs min=62.55µs  med=130.08µs max=2.68ms   p(90)=239.55µs p(95)=290.01µs
     http_req_sending...............: avg=26.41µs  min=8.25µs   med=21.73µs  max=169.92µs p(90)=39.49µs  p(95)=49.68µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=150.8ms  min=16.49ms  med=96.33ms  max=936.6ms  p(90)=364.7ms  p(95)=424.22ms
     http_reqs......................: 400     1.661897/s
     iteration_duration.............: avg=812.22ms min=218.54ms med=858.78ms max=1.74s    p(90)=1.1s     p(95)=1.16s   
     iterations.....................: 75      0.311606/s
     vus............................: 0       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

@obulat obulat merged commit a0fd32a into main Oct 18, 2025
46 checks passed
@obulat obulat deleted the fix/pipe-character-in-hi branch October 18, 2025 05:41
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 🤝 Merged in Openverse PRs Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-frontend

@dhruvkb dhruvkb Awaiting requested review from dhruvkb dhruvkb is a code owner automatically assigned from WordPress/openverse-frontend

Assignees

No one assigned

Labels

💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Projects

Openverse PRs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build fails due to unplugin-vue-i18n error in hi.json caused by invalid pipe character

3 participants

@obulat @openverse-bot