티스토리 수익 글 보기
{{ message }}
Editor: Allow replacing the ‘PostLockedModal’ component #70586
Merged
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Jul 1, 2025
Comment on lines
+282
to
+284
| export default globalThis.IS_GUTENBERG_PLUGIN | ||
| ? withFilters( 'editor.PostLockedModal' )( PostLockedModal ) | ||
| : PostLockedModal; |
Member
Author
There was a problem hiding this comment.
We could also use a Symbol for a private filter, but this way we avoid unnecessarily wrapping the component.
const HOOK_NAME = globalThis.IS_GUTENBERG_PLUGIN
? 'editor.PostLockedModal'
: Symbol( 'editor.PostLockedModal' );|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you’re merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project’s expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.87 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 165bb69. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16006202554
|
t-hamano
approved these changes
Jul 3, 2025
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I also confirmed that when I set the IS_GUTENBERG_PLUGIN variable to false, the filter does not work.
Member
Author
|
Thanks for testing, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70537.
PR introduces a new
editor.PostLockedModalfilter, allowing replacement of thePostLockedModalcore component in editors.Note
The new filter is limited to the Gutenberg plugin and won’t ship in WordPress core, at least for now.
Why?
Prepares for the upcoming collaborating editing work in the block editor, which will be developed as a separate plugin.
Testing Instructions
Test Snippet
Testing Instructions for Keyboard
Same.